feat: Migrate renderless and simple filter components to composition API #1529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
victorcg88
reviewed
Jun 24, 2024
packages/x-components/src/x-modules/facets/components/filters/simple-filter.vue
Outdated
Show resolved
Hide resolved
Comment on lines
77
to
79
| const cssClasses = computed(() => ({ | ||
| 'x-simple-filter--is-selected': props.filter.selected | ||
| })); |
There was a problem hiding this comment.
This could be done directly on the template.
There was a problem hiding this comment.
This option doesn't work either.
victorcg88
reviewed
Jun 24, 2024
Comment on lines
4
to
5
| :class="cssClasses" | ||
| :clickEvents="_clickEvents" | ||
| :clickEvents="clickEventsEmit" |
There was a problem hiding this comment.
This is not having any effect on the Vue3 playground. Classes added by this component are not applied.
…mposition API BREAKING-CHANGE: use cssClasses prop to pass classes through the component in Vue 3 instead of class or :class when using RenderlessFilter or SimpleFilter components
diegopf
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and context
Type of change
What is the destination branch of this PR?
MainHow has this been tested?
Tests performed according to testing guidelines:
Checklist: