Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(semantic-queries): cancel track no results query on QueryPreviewUnmounted event #1507

Merged
merged 1 commit into from
Jun 7, 2024
Merged

fix(semantic-queries): cancel track no results query on QueryPreviewUnmounted event #1507

merged 1 commit into from
Jun 7, 2024

Conversation

joseacabaneros
Copy link
Member

Avoid overwritten it in every setup like https://github.com/empathyco/x-cdl-next/pull/65/files#diff-5234d322c5ec99023ee64be6623c337f6892759ca3aec56b54904f5a10fcdff6

Type of change

  • Bug fix (non-breaking change that fixes an issue)

What is the destination branch of this PR?

  • Main

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review on my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

@joseacabaneros joseacabaneros requested a review from a team as a code owner June 5, 2024 16:09
@joseacabaneros joseacabaneros merged commit cc6518e into main Jun 7, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lauramargar lauramargar lauramargar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joseacabaneros @lauramargar