Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: migrate RTs module to composition API #1498

Merged

Conversation

lauramargar
Copy link
Contributor

@lauramargar lauramargar commented Jun 3, 2024

Pull request template

Migrate related-tags module to composition API.
This module contains the following components:

  • RelatedTags
  • RelatedTag

Motivation and context

  • Dependencies. If any, specify:
  • Open issue. If applicable, link: EMP-4193

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that causes existing functionality to not work as expected)
  • Change requires a documentation update

What is the destination branch of this PR?

  • Main
  • Other. Specify:

How has this been tested?

Tests performed according to testing guidelines:

@lauramargar lauramargar changed the title feat: Migrate RTs module to composition API feat: migrate RTs module to composition API Jun 6, 2024
@lauramargar lauramargar marked this pull request as ready for review June 11, 2024 13:55
@lauramargar lauramargar requested a review from a team as a code owner June 11, 2024 13:55
Comment on lines +161 to +162
clickRelatedTag,
shouldHighlightCurated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
clickRelatedTag,
shouldHighlightCurated
shouldHighlightCurated,
clickRelatedTag

@diegopf diegopf merged commit 22c5325 into main Jun 12, 2024
3 checks passed
@diegopf diegopf deleted the feature/migrate-related-tags-x-module-to-composition-api branch June 12, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants