Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: migrate history queries x module to composition api #1494

Conversation

lauramargar
Copy link
Contributor

@lauramargar lauramargar commented May 30, 2024

Pull request template

Migrate history-queries x-module to composition API.

Components to migrate:

  • HistoryQuery
  • HistoryQueries
  • ClearHistoryQueries
  • HistoryQueriesSwitch
  • MyHistory
  • RemoveHistoryQuery

Motivation and context

  • Dependencies. If any, specify:
  • Open issue. If applicable, link: EMP-416

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that causes existing functionality to not work as expected)
  • Change requires a documentation update

What is the destination branch of this PR?

  • Main
  • Other. Specify:

How has this been tested?

Tests performed according to testing guidelines:

@lauramargar lauramargar requested a review from a team as a code owner May 30, 2024 09:00
Copy link
Contributor

@victorcg88 victorcg88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job 💪. I added some minor suggestions.

Copy link
Member

@joseacabaneros joseacabaneros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One module less 👏🏾

@joseacabaneros joseacabaneros merged commit cd51e9b into main Jun 12, 2024
4 checks passed
@diegopf diegopf deleted the feature/EMP-4164-migrate-history-queries-x-module-to-composition-api branch October 24, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants