-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: migrate history queries x module to composition api #1494
Merged
joseacabaneros
merged 10 commits into
main
from
feature/EMP-4164-migrate-history-queries-x-module-to-composition-api
Jun 12, 2024
Merged
feat: migrate history queries x module to composition api #1494
joseacabaneros
merged 10 commits into
main
from
feature/EMP-4164-migrate-history-queries-x-module-to-composition-api
Jun 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
victorcg88
reviewed
May 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job 💪. I added some minor suggestions.
packages/x-components/src/x-modules/history-queries/components/remove-history-query.vue
Outdated
Show resolved
Hide resolved
packages/x-components/src/x-modules/history-queries/components/my-history.vue
Outdated
Show resolved
Hide resolved
packages/x-components/src/x-modules/history-queries/components/history-query.vue
Outdated
Show resolved
Hide resolved
packages/x-components/src/x-modules/history-queries/components/history-queries-switch.vue
Outdated
Show resolved
Hide resolved
packages/x-components/src/x-modules/history-queries/components/my-history.vue
Outdated
Show resolved
Hide resolved
packages/x-components/src/x-modules/history-queries/components/history-queries.vue
Outdated
Show resolved
Hide resolved
packages/x-components/src/x-modules/history-queries/components/history-queries-switch.vue
Outdated
Show resolved
Hide resolved
packages/x-components/src/x-modules/history-queries/components/clear-history-queries.vue
Outdated
Show resolved
Hide resolved
packages/x-components/src/x-modules/history-queries/components/clear-history-queries.vue
Outdated
Show resolved
Hide resolved
packages/x-components/src/x-modules/history-queries/components/history-queries-switch.vue
Outdated
Show resolved
Hide resolved
packages/x-components/src/x-modules/history-queries/components/history-queries-switch.vue
Outdated
Show resolved
Hide resolved
packages/x-components/src/x-modules/history-queries/components/history-query.vue
Show resolved
Hide resolved
packages/x-components/src/x-modules/history-queries/components/my-history.vue
Show resolved
Hide resolved
packages/x-components/src/x-modules/history-queries/components/remove-history-query.vue
Show resolved
Hide resolved
…before using components (#1512)
joseacabaneros
approved these changes
Jun 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One module less 👏🏾
diegopf
deleted the
feature/EMP-4164-migrate-history-queries-x-module-to-composition-api
branch
October 24, 2024 09:52
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request template
Migrate history-queries x-module to composition API.
Components to migrate:
HistoryQuery
HistoryQueries
ClearHistoryQueries
HistoryQueriesSwitch
MyHistory
RemoveHistoryQuery
Motivation and context
Type of change
What is the destination branch of this PR?
Main
How has this been tested?
Tests performed according to testing guidelines: