Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid showing empty empathize #1492

Merged
merged 1 commit into from
May 29, 2024
Merged

fix: avoid showing empty empathize #1492

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 21 additions & 7 deletions packages/_vue3-migration-test/src/x-modules/empathize/test-empathize.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,25 +1,39 @@
<template>
<SearchInput />
<Empathize :animation="CollapseHeight" class="empathize">
<h1>It is a Empathize</h1>
<h2>It is a Empathize</h2>
<h3>It is a Empathize</h3>
<p>
Component containing the empathize. It has a required slot to define its content and two props
to define when to open and close it: `eventsToOpenEmpathize` and `eventsToCloseEmpathize`.
</p>
<div v-if="showContent">
<h1>It is a Empathize</h1>
<h2>It is a Empathize</h2>
<h3>It is a Empathize</h3>
<p>
Component containing the empathize. It has a required slot to define its content and two
props to define when to open and close it: `eventsToOpenEmpathize` and
`eventsToCloseEmpathize`.
</p>
</div>
</Empathize>
<Empathize :animation="CollapseHeight" class="empathize" />
<button @click="toggleContent">
{{ showContent ? 'hide empathize content' : 'show empathize content' }}
</button>
</template>

<script setup lang="ts">
import { ref } from 'vue';
import CollapseHeight from '../../../../x-components/src/components/animations/collapse-height.vue';
import Empathize from '../../../../x-components/src/x-modules/empathize/components/empathize.vue';
import SearchInput from '../../../../x-components/src/x-modules/search-box/components/search-input.vue';

const showContent = ref(true);
const toggleContent = () => {
showContent.value = !showContent.value;
};
</script>

<style scoped>
.empathize {
border: 3px solid red;
padding-top: 16px;
padding-bottom: 16px;
}
</style>
5 changes: 3 additions & 2 deletions packages/x-components/src/x-modules/empathize/components/empathize.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
</template>

<script lang="ts">
import { computed, defineComponent, PropType, ref } from 'vue';
import { defineComponent, PropType, ref } from 'vue';
import { NoElement } from '../../../components/no-element';
import { useDebounce } from '../../../composables/use-debounce';
import { useRegisterXModule } from '../../../composables/use-register-x-module';
Expand Down Expand Up @@ -64,7 +64,7 @@
const empathizeRef = ref<HTMLDivElement>();

const isOpen = ref(false);
const hasContent = computed(() => !!empathizeRef.value?.children.length);
const hasContent = ref(!!empathizeRef.value?.children.length);

/**
* Changes the state of {@link Empathize.isOpen} assigning to it the value of `newOpen`
Expand All @@ -87,6 +87,7 @@
* element.
*/
function open() {
hasContent.value = !!empathizeRef.value?.children.length;
if (hasContent.value) {
changeOpen(true);
}
Expand Down
Loading