Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Migrate base-panels components to composition api #1491

Merged
merged 13 commits into from
May 31, 2024
Merged

Feat: Migrate base-panels components to composition api #1491

merged 13 commits into from
May 31, 2024

Conversation

andreadlgdo
Copy link
Contributor

@andreadlgdo andreadlgdo commented May 29, 2024 •
edited by jira bot
Loading

Pull request template

Describe the purpose of the change, the specific changes done in detail, and the issue you have fixed.

Motivation and context

  • Dependencies. If any, specify:
  • Open issue. If applicable, link: EMP-4154

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that causes existing functionality to not work as expected)
  • Change requires a documentation update

What is the destination branch of this PR?

  • Main
  • Other. Specify:

How has this been tested?

Tests performed according to testing guidelines:

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review on my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

@andreadlgdo andreadlgdo self-assigned this May 29, 2024
@andreadlgdo andreadlgdo requested a review from a team as a code owner May 29, 2024 06:46
victorcg88
victorcg88 previously approved these changes May 29, 2024
View reviewed changes
Copy link
Contributor

@victorcg88 victorcg88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

packages/x-components/src/components/panels/base-tabs-panel.vue Show resolved Hide resolved
packages/x-components/src/components/panels/base-id-toggle-panel-button.vue Outdated Show resolved Hide resolved
@andreadlgdo andreadlgdo requested a review from victorcg88 May 30, 2024 06:14
victorcg88
victorcg88 previously approved these changes May 30, 2024
View reviewed changes
@andreadlgdo andreadlgdo requested review from victorcg88 May 30, 2024 12:59
@andreadlgdo
Merge branch 'main' into feat/EMP-4154-migrate-panels-components-to-c…
2a51a43 
…omposition-api

# Conflicts:
#	packages/_vue3-migration-test/src/components/index.ts
#	packages/_vue3-migration-test/src/router.ts
victorcg88
victorcg88 previously approved these changes May 30, 2024
View reviewed changes
@andreadlgdo
Merge branch 'main' into feat/EMP-4154-migrate-panels-components-to-c…
68db842 
…omposition-api

# Conflicts:
#	packages/_vue3-migration-test/src/components/index.ts
#	packages/_vue3-migration-test/src/router.ts
@diegopf diegopf merged commit 077ad4d into main May 31, 2024
4 checks passed
@diegopf diegopf deleted the feat/EMP-4154-migrate-panels-components-to-composition-api branch May 31, 2024 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@victorcg88 victorcg88 victorcg88 approved these changes

@diegopf diegopf diegopf approved these changes

Assignees

@andreadlgdo andreadlgdo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andreadlgdo @diegopf @victorcg88