Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(animation): fix Expected Object, got Function on animations props #1489

Merged
merged 4 commits into from
May 30, 2024
Merged

fix(animation): fix Expected Object, got Function on animations props #1489

merged 4 commits into from
May 30, 2024

Conversation

joseacabaneros
Copy link
Member

Issue performed while updating x dependencies in motive-x

Screenshot 2024-05-28 at 6 46 14 PM

Type of change

  • Vue 3 migration

What is the destination branch of this PR?

  • Main

How has this been tested?

In motive-x

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review on my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

@joseacabaneros joseacabaneros requested a review from a team as a code owner May 28, 2024 16:51
@diegopf diegopf merged commit 4467edc into main May 30, 2024
4 checks passed
@diegopf diegopf deleted the fix-animation-prop-types branch May 30, 2024 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@victorcg88 victorcg88 victorcg88 approved these changes

@diegopf diegopf diegopf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joseacabaneros @diegopf @victorcg88