Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(highlight): migrate highlight component to composition API #1486

Merged
merged 1 commit into from
May 30, 2024
Merged

feat(highlight): migrate highlight component to composition API #1486

merged 1 commit into from
May 30, 2024

Conversation

victorcg88
Copy link
Contributor

@victorcg88 victorcg88 commented May 28, 2024 •
edited
Loading

Migrate highlight component to composition API.

  • Open issue. If applicable, link: EMP-4155

Type of change

Vue 3 migration

What is the destination branch of this PR?

  • Main

How has this been tested?

Tests performed according to testing guidelines:

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review on my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

@victorcg88 victorcg88 requested a review from a team as a code owner May 28, 2024 14:19
@victorcg88 victorcg88 force-pushed the feat/EMP-4155-migrate-highlight-component branch from b7c6b53 to 0c19082 Compare May 29, 2024 07:02
diegopf
diegopf previously approved these changes May 30, 2024
View reviewed changes
@victorcg88 victorcg88 force-pushed the feat/EMP-4155-migrate-highlight-component branch from 0c19082 to e06c687 Compare May 30, 2024 07:51
@diegopf diegopf merged commit 10dd541 into main May 30, 2024
4 checks passed
@diegopf diegopf deleted the feat/EMP-4155-migrate-highlight-component branch May 30, 2024 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diegopf diegopf diegopf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@victorcg88 @diegopf