Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(empathize): migrate empathize component to composition API #1481

Merged
merged 2 commits into from
May 28, 2024

Conversation

joseacabaneros
Copy link
Member

Migrate Empathize component to composition API and improve implementation

  • Open issue. If applicable, link: EMP-4087

Type of change

  • Vue 3 migration

What is the destination branch of this PR?

  • Main

How has this been tested?

_vue3 package

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review on my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

@joseacabaneros joseacabaneros requested a review from a team as a code owner May 24, 2024 10:36
diegopf
diegopf previously approved these changes May 27, 2024
@diegopf diegopf merged commit ae34083 into main May 28, 2024
4 checks passed
@diegopf diegopf deleted the EMP-4087-empathize-composition-api branch May 28, 2024 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants