Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(base-modal): migrate base-modal component and side effects #1479

Merged
merged 3 commits into from
May 28, 2024
Merged

feat(base-modal): migrate base-modal component and side effects #1479

merged 3 commits into from
May 28, 2024

Conversation

joseacabaneros
Copy link
Member

Migrate BaseModal component to Composition API and some side effects like:

  • !important in Fade. I think it is a win-win because opacity in BaseModal has always more specificity than transition animation, and it doesn't animate. I know it is hardcoded in motive-x for every modal.
  • Removed many hacks in the component.
  • Replaced @Debounce decorator by useDebounce composable
  • Open issue. If applicable, link: EMP-4087

Type of change

  • Vue 3 migration

What is the destination branch of this PR?

  • Main

How has this been tested?

Tests performed according to testing guidelines:

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review on my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

@joseacabaneros joseacabaneros requested a review from a team as a code owner May 22, 2024 15:28
@joseacabaneros
Merge remote-tracking branch 'origin/main' into EMP-4087-refactor-bas…
1fe6c43 
…e-modal

# Conflicts:
#	packages/_vue3-migration-test/src/router.ts
lauramargar
lauramargar previously approved these changes May 27, 2024
View reviewed changes
Copy link
Contributor

@lauramargar lauramargar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!! 👏🏽

victorcg88
victorcg88 approved these changes May 28, 2024
View reviewed changes
Copy link
Contributor

@victorcg88 victorcg88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM. Tested locally and working fine in both vue3 playground and x-demo.

packages/_vue3-migration-test/src/components/modals/test-base-modal.vue
<button @click="open = true">Open modal</button>
<BaseModal
@click:overlay="open = false"
@focusin:body="open = false"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@diegopf diegopf merged commit 610ec16 into main May 28, 2024
4 checks passed
@diegopf diegopf deleted the EMP-4087-refactor-base-modal branch May 28, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@victorcg88 victorcg88 victorcg88 approved these changes

@diegopf diegopf diegopf approved these changes

@lauramargar lauramargar lauramargar left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@joseacabaneros @diegopf @victorcg88 @lauramargar