feat: migrate FiltersInjection mixin
#1467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diegopf
reviewed
May 13, 2024
packages/_vue3-migration-test/src/x-modules/facets/components/test-filters-injection.vue
Outdated
Show resolved
Hide resolved
packages/x-components/src/x-modules/facets/components/lists/exclude-filters-with-no-results.vue
Outdated
Show resolved
Hide resolved
packages/x-components/src/x-modules/facets/components/lists/filters-search.vue
Outdated
Show resolved
Hide resolved
packages/x-components/src/x-modules/facets/components/lists/filters-search.vue
Outdated
Show resolved
Hide resolved
packages/_vue3-migration-test/src/x-modules/facets/components/test-filters-injection.vue
Outdated
Show resolved
Hide resolved
packages/_vue3-migration-test/src/x-modules/facets/components/test-filters-injection.vue
Outdated
Show resolved
Hide resolved
diegopf
reviewed
May 13, 2024
packages/x-components/src/x-modules/facets/components/lists/sorted-filters.vue
Outdated
Show resolved
Hide resolved
diegopf
reviewed
May 13, 2024
joseacabaneros
previously approved these changes
May 14, 2024
packages/x-components/src/composables/__tests__/use-filters-injection.spec.ts
Outdated
Show resolved
Hide resolved
joseacabaneros
approved these changes
May 15, 2024
diegopf
approved these changes
May 15, 2024
diegopf
deleted the
feature/EMP-4044-replace-filters-injection-mixin-by-use-filters-injection-composable
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request template
Migrate FiltersInjection mixin.
The initial idea was to migrate all components that use this mixin and then remove it. I have created a new composable (
use-filters-injection.ts). The components involved are:Motivation and context
Type of change
What is the destination branch of this PR?
MainHow has this been tested?
Tests performed according to testing guidelines:
Checklist: