-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(query-preview): migrate query preview component x provide #1452
Merged
joseacabaneros
merged 8 commits into
main
from
feature/EMP-3794-migrate-query-preview-component-x-provide
Apr 29, 2024
Merged
refactor(query-preview): migrate query preview component x provide #1452
joseacabaneros
merged 8 commits into
main
from
feature/EMP-3794-migrate-query-preview-component-x-provide
Apr 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CachedaCodes
approved these changes
Apr 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What a lot of changes, and the tests pass without touching them! 👏🏾
packages/x-components/src/x-modules/queries-preview/components/query-preview-list.vue
Outdated
Show resolved
Hide resolved
packages/x-components/src/x-modules/queries-preview/components/query-preview-list.vue
Outdated
Show resolved
Hide resolved
packages/x-components/src/x-modules/queries-preview/components/query-preview-list.vue
Outdated
Show resolved
Hide resolved
packages/x-components/src/x-modules/queries-preview/components/query-preview-list.vue
Outdated
Show resolved
Hide resolved
packages/x-components/src/x-modules/queries-preview/components/query-preview-list.vue
Outdated
Show resolved
Hide resolved
packages/x-components/src/x-modules/queries-preview/components/query-preview-list.vue
Outdated
Show resolved
Hide resolved
joseacabaneros
approved these changes
Apr 26, 2024
lauramargar
deleted the
feature/EMP-3794-migrate-query-preview-component-x-provide
branch
April 30, 2024 06:14
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request template
Migrate QueryPreview and QueryPreviewList components to vue 2.7 syntax.
Motivation and context
Type of change
What is the destination branch of this PR?
Main
How has this been tested?
Queries previews are working as expected. Cache should be saved when it's needed and queries preview should be displayed.
Checklist: