Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(query-preview): migrate query preview component x provide #1452

Merged

Conversation

lauramargar
Copy link
Contributor

@lauramargar lauramargar commented Apr 24, 2024

Pull request template

Migrate QueryPreview and QueryPreviewList components to vue 2.7 syntax.

Motivation and context

  • Dependencies. If any, specify:
  • Open issue. If applicable, link: EMP-3794

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that causes existing functionality to not work as expected)
  • Change requires a documentation update

What is the destination branch of this PR?

  • Main
  • Other. Specify:

How has this been tested?

Queries previews are working as expected. Cache should be saved when it's needed and queries preview should be displayed.

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review on my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

@lauramargar lauramargar requested a review from a team as a code owner April 24, 2024 07:39
Copy link
Member

@joseacabaneros joseacabaneros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What a lot of changes, and the tests pass without touching them! 👏🏾

@joseacabaneros joseacabaneros merged commit a60c62a into main Apr 29, 2024
4 checks passed
@lauramargar lauramargar deleted the feature/EMP-3794-migrate-query-preview-component-x-provide branch April 30, 2024 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants