-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Migrate result variant provider #1440
Merged
lauramargar
merged 18 commits into
main
from
feature/EMP-3793-Migrate-result-variant-provider
Apr 8, 2024
Merged
Feature: Migrate result variant provider #1440
lauramargar
merged 18 commits into
main
from
feature/EMP-3793-Migrate-result-variant-provider
Apr 8, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annacv
changed the title
Feature/emp 3793 migrate result variant provider
Feature: Migrate result variant provider
Apr 2, 2024
lauramargar
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The branch will be updated after result variant selector is validated/merged, so it should be reviewed afterward.
Migrate the result variant provider component:
XProvide
decorator with Vue native one.ref
s to react to selector component changes.ComputedRef
to make it watchable (setting it as aref
is not enough, asprops
are not reactive by default).ref
type fromselectResultVariant
, as it is not aref
, but a function that checks aref
(selectedVariants
).Pull request template
Proceed to Vue 3 migration.
Motivation and context
Type of change
What is the destination branch of this PR?
Main
How has this been tested?
It can be tested by using a local build inside oysho's customer's setup and checking result component behavior & events in Vue DevTools:
click
event is fired with correct metadata (color'sid
,name
andimage
).SizeAdd2Cart
event is fired with the correct metadata (theresult
and thesize
objects with the corresponding color and size information).Tests performed according to testing guidelines:
Checklist: