-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Modify use-$x composable #1434
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CachedaCodes
suggested changes
Mar 26, 2024
target: baseEventButton.element | ||
}); | ||
}); | ||
// TODO: Uncomment test when BaseEventButton component is migrated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't skip the test by commenting it, use it.skip
lauramargar
approved these changes
Apr 3, 2024
albertjcuac
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and context
The xPlugin is responsible for creating the $x in every component instance through the xplugin.mixin. Currently the use$x composable is just returning a reference to this property. In order to get rid of this mixin we need that the use$x is able to create and return the same $x API.
Take into account: 3 tests have been disabled for 2 components using BaseEventButton with the old $x API and checked that migrating BaseEventButton these component tests will pass. The migrated component is inside this test branch for checking: https://github.com/empathyco/x/tree/feature/Base-event-button-migrated.
Type of change
What is the destination branch of this PR?
Main
How has this been tested?
Browse along all the app & make sure:
Tests performed according to testing guidelines:
Checklist: