Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Modify use-$x composable #1434

Merged
merged 12 commits into from
Apr 4, 2024

Conversation

annacv
Copy link
Contributor

@annacv annacv commented Mar 21, 2024

Motivation and context

The xPlugin is responsible for creating the $x in every component instance through the xplugin.mixin. Currently the use$x composable is just returning a reference to this property. In order to get rid of this mixin we need that the use$x is able to create and return the same $x API.

Take into account: 3 tests have been disabled for 2 components using BaseEventButton with the old $x API and checked that migrating BaseEventButton these component tests will pass. The migrated component is inside this test branch for checking: https://github.com/empathyco/x/tree/feature/Base-event-button-migrated.

  • Dependencies. If any, specify:
  • Open issue. If applicable, link: EMP-3656

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that causes existing functionality to not work as expected)
  • Change requires a documentation update

What is the destination branch of this PR?

  • Main
  • Other. Specify:

How has this been tested?

Browse along all the app & make sure:

  • All modules are registered on init
  • All features are working as expected

Tests performed according to testing guidelines:

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review on my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

@annacv annacv requested a review from a team as a code owner March 21, 2024 15:41
@annacv annacv marked this pull request as draft March 21, 2024 15:43
@annacv annacv marked this pull request as ready for review March 25, 2024 16:36
target: baseEventButton.element
});
});
// TODO: Uncomment test when BaseEventButton component is migrated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't skip the test by commenting it, use it.skip

@annacv annacv requested a review from CachedaCodes March 26, 2024 09:11
@lauramargar lauramargar merged commit cd9a0d1 into main Apr 4, 2024
4 checks passed
@lauramargar lauramargar deleted the feature/EMP-3656-Modify-use-x-composable branch April 4, 2024 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants