Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/emp 3542 migrate global x bus component #1429

Merged
merged 15 commits into from
Mar 13, 2024

Conversation

albertjcuac
Copy link
Contributor

@albertjcuac albertjcuac commented Mar 11, 2024

Pull request template

For the vue 3 migration we need to migrate components to 2.7.
Snippet callbacks tests have been commented because they have not been migrated yet and they use globalXbus , so we need to avoid them failling for this PR and fix them in the Snippet Callbacks migration task.

Motivation and context

  • Dependencies. If any, specify:
  • Open issue. If applicable, link: EMP-3542

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that causes existing functionality to not work as expected)
  • Change requires a documentation update

What is the destination branch of this PR?

  • Main
  • Other. Specify:

How has this been tested?

Tests performed according to testing guidelines:

testing it still works following the docs usage: link

@albertjcuac albertjcuac requested a review from a team as a code owner March 11, 2024 07:41
Copy link
Contributor

@annacv annacv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@CachedaCodes CachedaCodes merged commit 48c8ff5 into main Mar 13, 2024
4 checks passed
@CachedaCodes CachedaCodes deleted the feature/EMP-3542-Migrate-GlobalXBus-component branch March 13, 2024 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants