feat: change useHybridInject so it works more like vue inject #1427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annacv
deleted the
feature/EMP-3636-redo-useHybridInject-so-it-works-more-like-regular-inject
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EMP-3636
Pull request template
useHybridInjectand vue's regularinjectweren't behaving the same, so we made some changes in the composable.Motivation and context
Handling reactiveness wasn't working as expected.
Type of change
What is the destination branch of this PR?
MainHow has this been tested?
Use
useHybridInjectto inject the snippet config, wrap that call in arefand try to watch changes in thefiltersproperty when changing its array value.