refactor: migrate location-provider component to vue 2.7 #1421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CachedaCodes
suggested changes
Feb 21, 2024
| export default defineComponent({ | ||
| name: 'LocationProvider', | ||
| props: { | ||
| location: { |
Comment on lines
22
to
27
| /** | ||
| * The {@link FeatureLocation} to provide. | ||
| * | ||
| * @public | ||
| */ | ||
| provide('location', locationFeature); |
There was a problem hiding this comment.
This doesn't need docs, the prop above does.
| } | ||
| }, | ||
| setup(props, { slots }) { | ||
| const locationFeature = toRef(props, 'location'); |
There was a problem hiding this comment.
I think calling it just location works well here. Also, the name indicates something that is a feature about locations, not the location of a feature. The type is FeatureLocation so, if you want to keep the feature part, the name should be featureLocation.
CachedaCodes
approved these changes
Feb 23, 2024
CachedaCodes
deleted the
feature/EMP-3541-migrate-location-provider-component
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EMP-3541
Motivation and context
For the vue 3 migration we need to migrate components to 2.7
Type of change
What is the destination branch of this PR?
MainHow has this been tested?
Follow the docs in the component to tests that the feature still works correctly