feature(composable): create utility composable useHybridInject #1418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annacv
reviewed
Feb 20, 2024
|
|
||
| /** | ||
| * Function to use a hybrid inject, which allows to inject a value provided by the regular provide | ||
| * of vue or by the XProvide decorator. |
There was a problem hiding this comment.
Suggested change
| * of vue or by the XProvide decorator. | |
| * of vue or by the XProvide decorator. |
…gration' of github.com:empathyco/x into feature/EMP-3558-utility-composable-to-handle-inject-migration
CachedaCodes
deleted the
feature/EMP-3558-utility-composable-to-handle-inject-migration
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EMP-3558
Motivation and context
The regular vue 3
injectdoesn't work with theXProvide, so this utility composable functions as a stepping stone for the migration between the two. It works with any of them and it should be removed when the migration to vue 3 is completed.Type of change
What is the destination branch of this PR?
MainHow has this been tested?
Create a injected test vue component and a provider test vue component. Wrap the injected test component in the provider. Now, the injected test component should use the composable and the provider component should do the providing.
Create the provider component so it uses the
@XProviderdecorator and has a dynamic property that provides to its children (for example, a property that changes with a button). The injected test component should pick it up correctly and change dynamically. Then, do the same but withdefineComponentand the vue 3provide.Unit tests not created due to this being a utility that will be removed in the future.