-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: create useState composable #1402
Merged
CachedaCodes
merged 8 commits into
main
from
feature/EMP-3458-create-a-use-state-composable
Feb 13, 2024
Merged
Changes from 3 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
0f86bf2
feat: create useState composable
lauramargar bd42d26
feat: move useState composable into useStore
lauramargar 1aa1105
feat: new approach for useStore composable
lauramargar 2f224db
feat: new approach for useStore composable
lauramargar 0b7e510
chore: separate useState composable from useStore && add useState tests
lauramargar 358540e
chore: separate useState composable from useStore && add useState tests
lauramargar 395b545
chore: fix useState types
lauramargar 2056d23
chore: fix pr comments
lauramargar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,13 +1,40 @@ | ||
import { getCurrentInstance } from 'vue'; | ||
import { computed, ComputedRef, getCurrentInstance } from 'vue'; | ||
import { Store } from 'vuex'; | ||
import { Dictionary } from '@empathyco/x-utils'; | ||
import { ExtractState, XModuleName } from '../x-modules/x-modules.types'; | ||
|
||
/** | ||
* Function which returns the `$store` object from the current component instance. | ||
* Function which returns the `$store` object from the current component instance | ||
* and the selected state as a dictionary of paths. | ||
* | ||
* @returns The `$store` object from the current component instance. | ||
* @param module - The {@link XModuleName} of the getter. | ||
* @returns The state properties of the module and the `$store`. | ||
* | ||
* @public | ||
*/ | ||
export function useStore(): Store<any> { | ||
return (getCurrentInstance()?.proxy as { $store: Store<any> }).$store; | ||
export function useStore<Module extends XModuleName, Path extends keyof ExtractState<Module>>( | ||
module?: Module | ||
): UseStore<Module, Path> { | ||
const store = (getCurrentInstance()?.proxy as { $store: Store<any> }).$store; | ||
const useState = (module: Module, paths: Path[]): ComputedRef<Dictionary<keyof Path>> => { | ||
return paths.reduce<ComputedRef<Dictionary<keyof Path>>>((state, path) => { | ||
// eslint-disable-next-line @typescript-eslint/ban-ts-comment | ||
// @ts-ignore | ||
state[path] = computed(() => store.state.x[module][path]); | ||
return state; | ||
}, {} as ComputedRef<Dictionary<keyof Path>>); | ||
}; | ||
const useStateWithModule = useState.bind(module); | ||
return { | ||
store, | ||
useState: module ? useStateWithModule : useState | ||
}; | ||
} | ||
|
||
/** | ||
* Return type of the {@link useStore} composable. | ||
*/ | ||
type UseStore<Module extends XModuleName, Path extends keyof ExtractState<Module>> = { | ||
store: Store<any>; | ||
useState: (module: Module, paths: Path[]) => ComputedRef<Dictionary<keyof Path>>; | ||
}; |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The types for the useStore are wrong. We don't have a ComputedRef of a Dictionary but the other way around. It should be something like:
For this first iteration I would skip the use case of passing the module as argument.