fix: refactor snippet-config-extra-params to use watchers preventing false event firing #1393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…false event firing
diegopf
reviewed
Jan 16, 2024
CachedaCodes
deleted the
fix/EMP-3052-false-firing-of-ExtraParamsProvided
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EMP-3052
Motivation and context
The component
SnippetConfigExtraParamswas causing the firing of the eventExtraParamsProvidedwhen the snippet config changed, even if the extra params didn't actually change. This PR changes the logic from a computed property to two watchers, preventing the bug.Type of change
What is the destination branch of this PR?
MainHow has this been tested?
Check that updating a parameter in the snippet config with
InterfaceX.setSnippetConfigthat is exclueded from the extra params doesn't fireExtraParamsProvided.