feat(components): new component to wrap components so a display event is emitted when they appear in the viewport for the first time #1391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… is emitted when they appear in the viewport for the first time
Base automatically changed from
feature/EMP-3241-display-tagging-in-query-preview
to
main
January 15, 2024 16:13
diegopf
reviewed
Jan 19, 2024
diegopf
reviewed
Jan 19, 2024
| const { isElementVisible, unwatchDisplay } = useOnDisplay({ | ||
| element, | ||
| callback: callbackSpy, | ||
| ...(!triggerOnce && { triggerOnce }) |
There was a problem hiding this comment.
Suggested change
| ...(!triggerOnce && { triggerOnce }) | |
| triggerOnce |
what am I missing here? why do all that?😅
There was a problem hiding this comment.
So If I send null it doesn't send anything to the method, which doesn't make sense because I have true by default, so I'm actually not testing if the composable sets triggerOnce = true by default because I was doing it manually in this function.
…is-visible # Conflicts: # packages/x-adapter-platform/src/mappers/responses/__tests__/__snapshots__/search-response.mapper.spec.ts.snap
herrardo
reviewed
Jan 22, 2024
CachedaCodes
deleted the
feature/EMP-3243-emit-events-when-component-is-visible
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EMP-3241
Motivation and context
We needed a way of emitting a display event when a specific component appeared in the viewport. This PR adds a new component that will do that with any component that is passed as slot.
Type of change
What is the destination branch of this PR?
MainHow has this been tested?
The query previews in the
homecomponent are wrapped by the new component. Test it by checking if a display event is emitted when they appear in the viewport.