Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(search): handle display tagging from search response #1388

Merged
merged 6 commits into from
Jan 12, 2024

Conversation

CachedaCodes
Copy link
Contributor

@CachedaCodes CachedaCodes commented Jan 3, 2024

EMP-3239

Motivation and context

A new field for the display tagging will be added to the search response to be used on the recommendations. This PR handles that new field for the search response types and the search module.

  • Dependencies. If any, specify:
  • Open issue. If applicable, link:

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that causes existing functionality to not work as expected)
  • Change requires a documentation update

What is the destination branch of this PR?

  • Main
  • Other. Specify:

@CachedaCodes CachedaCodes requested a review from a team as a code owner January 3, 2024 12:05
herrardo
herrardo previously approved these changes Jan 4, 2024
@annacv
Copy link
Contributor

annacv commented Jan 12, 2024

Cool @CachedaCodes !
Search state is saving the displayTagging:
Captura de pantalla 2024-01-12 a les 9 54 13

I doubt if we should also save this in the tagging state, as well as we do with the queryTagging in a queryTaggingInfo object. Anyway, if we think it is worth we can deal with it in another task.

Copy link
Contributor

@annacv annacv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just check this test: src/mappers/responses/__tests__/search-response.mapper.spec.ts

@annacv annacv self-requested a review January 12, 2024 09:06
Copy link
Contributor

@annacv annacv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@annacv annacv merged commit b6b5d86 into main Jan 12, 2024
4 checks passed
@annacv annacv deleted the feature/EMP-3239-handle-search-display-tagging branch January 12, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants