feat(facets): Unify __unknown__ and __unknown-facet__ in a constant #1351
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request template
Create
UNKNOWN_FACET_KEY
constant to identify filters withoutfacetId
(RawFilter
).BREAKING CHANGES:
'__unknown-facet__'
value for afacetId
is deprecated: it has been replaced by theUNKNOWN_FACET_KEY
constant, whose value is'__unknown__'
.Motivation and context
Right now we’re identifying unknown facets giving them either
__unknown__
or__unknown-facet__
as id.We should unify this and use a constant instead of a plain string.
Type of change
What is the destination branch of this PR?
Main
How has this been tested?
Tests performed according to testing guidelines:
Checklist: