Fix/exports for experience controls #1312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat(xcontrols): added files for create skeleton Co-authored-by: Ana Fernández Ostio <[email protected]> * fix(xcontrols): rename package + add skeleton Basic Skeleton added to some files that were empty Co-Authored-By: Matías García Gimeno <[email protected]> Co-Authored-By: Ger-28 <[email protected]> --------- Co-authored-by: Ana Fernández Ostio <[email protected]> Co-authored-by: Ana Fernández Ostio <[email protected]> Co-authored-by: Ger-28 <[email protected]>
EMP-2056 --------- Co-authored-by: Matias Garcia <[email protected]> Co-authored-by: Ana Fernández Ostio <[email protected]> Co-authored-by: Matías García Gimeno <[email protected]> Co-authored-by: Ger-28 <[email protected]>
EMP-2056 --------- Co-authored-by: Ana Fernández Ostio <[email protected]> Co-authored-by: Ana Fernández Ostio <[email protected]> Co-authored-by: Ana Fernández Ostio <[email protected]>
EMP-2064 --------- Co-authored-by: Ana Fernández Ostio <[email protected]> Co-authored-by: Ana Fernández Ostio <[email protected]> Co-authored-by: Ana Fernández Ostio <[email protected]>
EMP-2056 --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Matias Garcia <[email protected]> Co-authored-by: Ana Fernández Ostio <[email protected]> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Matías García Gimeno <[email protected]> Co-authored-by: Guillermo Cacheda <[email protected]> Co-authored-by: empathy/x <[email protected]> Co-authored-by: acondal <[email protected]> Co-authored-by: mariorey <[email protected]> Co-authored-by: Gerardo Vázquez <[email protected]> Co-authored-by: lauramargar <[email protected]> Co-authored-by: Ger-28 <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
EMP-2048 --------- Co-authored-by: Matías García Gimeno <[email protected]> Co-authored-by: Ger-28 <[email protected]>
…1306) EMP-2136 --------- Co-authored-by: Ger-28 <[email protected]> Co-authored-by: Guillermo <[email protected]>
…te-endpoint-adapter # Conflicts: # packages/x-types/package.json # pnpm-lock.yaml
…dapter definition
…ience-controls # Conflicts: # packages/x-components/src/x-modules/experience-controls/store/actions/fetch-and-save-experience-controls.action.ts # packages/x-components/src/x-modules/experience-controls/store/types.ts
lauramargar
previously approved these changes
Oct 5, 2023
lauramargar
approved these changes
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and context
The experience-controls module was missing the barrels in some folders
Type of change
What is the destination branch of this PR?
MainHow has this been tested?
Install it locally in the archetype and check that you can import form the experience-controls module