feat: add filters to the query preview request #1292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
herrardo
reviewed
Sep 19, 2023
CachedaCodes
suggested changes
Sep 19, 2023
packages/x-components/src/x-modules/queries-preview/components/query-preview.vue
Show resolved
Hide resolved
| @@ -161,11 +162,19 @@ | |||
| feature: this.queryFeature, | |||
| location: this.location | |||
| }); | |||
|
|
|||
| const filtersApply = this.queryPreviewInfo.filters?.reduce((filtersList, filterId) => { | |||
There was a problem hiding this comment.
Suggested change
| const filtersApply = this.queryPreviewInfo.filters?.reduce((filtersList, filterId) => { | |
| const filters = this.queryPreviewInfo.filters?.reduce((filtersList, filterId) => { |
| return { | ||
| query: this.queryPreviewInfo.query, | ||
| rows: this.config.maxItemsToRequest, | ||
| extraParams: { ...this.params, ...this.queryPreviewInfo.extraParams }, | ||
| filters: filtersApply, |
There was a problem hiding this comment.
Suggested change
| filters: filtersApply, | |
| filters, |
packages/x-components/src/x-modules/queries-preview/components/query-preview.vue
Show resolved
Hide resolved
packages/x-components/src/x-modules/queries-preview/components/query-preview.vue
Show resolved
Hide resolved
Co-authored-by: Gerardo Vázquez <[email protected]>
8 tasks
CachedaCodes
approved these changes
Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request template
Currently, the query preview component accept 2 params, title&query, so it creates it retrieves the products and show them in a viz, an sliding panel as default.
It would be great if we could add filters & extra params to the search request, now extra params are developed, so we also have to add filters. These params could help to narrow the results, that could be very interesting for some customers.
Motivation and context
Type of change
What is the destination branch of this PR?
MainHow has this been tested?
At
Home.vuefile add or remove filters inqueriesPreviewInfovar. The carrousels of query preview should be filtered.