feat: update tagging from banners and promoteds #1274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
herrardo
reviewed
Sep 4, 2023
| @@ -295,8 +295,6 @@ export const platformSearchResponse = { | |||
| title: 'Banner title', | |||
| url: 'https://assets.empathy.co/', | |||
| tagging: { | |||
There was a problem hiding this comment.
Shouldn't you add the same tagging object to the promoted response?
There was a problem hiding this comment.
Promoted didn't have any tagging object before (with the tagging&query object), so I understood that maybe it must be like this for some reason. But yes, I think that promoted response should contain the same tagging as banner response.
| @@ -409,7 +392,7 @@ Object { | |||
| "image": "https://assets.empathy.co/images-demo/31335.jpg", | |||
| "modelName": "Promoted", | |||
| "tagging": Object { | |||
| "query": Object { | |||
| "click": Object { | |||
There was a problem hiding this comment.
I would say that the tagging&click object of the promoted should be equal to the banner one
herrardo
approved these changes
Sep 6, 2023
CachedaCodes
deleted the
feature/EMP-1897-remove-invalid-url-messages-in-console-when-searching-in-the-archetype
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request template
The reason why we are receiving
Invalid URLmessages in the console is that the back is not sending the tagging in banners and promoteds. Both of these elements expect query tagging, but this tagging should be used once in the response, not in a single result of the response.So our proposal is to add, as optional, the click tagging in both elements (banner and promoted) and remove query tagging.
Motivation and context
Type of change
What is the destination branch of this PR?
MainHow has this been tested?
Search for a query with banner or promoted. You should obtain one
Invalid URLmessage for each element.(This messages should disappear when the back sends tagging fields)
Checklist: