-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Brand Recommendations animation on second time appearance #1267
Merged
CachedaCodes
merged 9 commits into
main
from
bugfix/EMP-1707-Brand-recommendations-wrong-reload
Sep 12, 2023
Merged
Changes from 8 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
1291e28
bugfix: load queryPreview with results once
annacv 284bd76
chore: load queryPreview with results once
annacv e2925c5
Merge remote-tracking branch 'origin/bugfix/EMP-1707-Brand-recommenda…
annacv 30a5894
feat: keep error catching if a success have no results
annacv c06c2a6
bugfix: delete QP from the state when the component is destroyed
annacv 93bfa18
feat: set queryList event in query list component
annacv f7a4b09
feat: set replaceable false to avoid replacing clearQueryPreview wire…
annacv d3c21e9
feat: rm unneded events
annacv bc6ae46
chore: PR fixes
annacv File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -17,4 +17,8 @@ export interface QueriesPreviewXEvents { | |
* Payload: The query whose preview has been removed. | ||
*/ | ||
QueryPreviewUnmountedHook: string; | ||
/** | ||
* The component that shows a Query preview has been destroyed. | ||
*/ | ||
QueriesPreviewDestroyedHook: void; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Remove this event |
||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
restore this imports as they were before