Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: prevent special characters from url #1266

Closed
wants to merge 8 commits into from
+6 −2
Closed

feat: prevent special characters from url #1266

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
79ce508
[EMP-1745]
lauramargar Aug 28, 2023
4a42549
chore: another approach related to the pr comments
lauramargar Aug 29, 2023
67a3d0a
Merge branch 'main' of https://github.com/empathyco/x into feature/EM…
lauramargar Aug 29, 2023
db1cd5f
chore: remove special keys from all params in URL
lauramargar Aug 30, 2023
f2c20b5
chore: add more cases to prevent html injection
lauramargar Aug 31, 2023
8e9b26d
chore: fix replace options
lauramargar Aug 31, 2023
461dd69
chore: pr comments
lauramargar Aug 31, 2023
eb64d7f
chore: new approach using sanitize util
lauramargar Sep 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions packages/x-components/src/x-modules/url/components/url-handler.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
import { FeatureLocation } from '../../../types/origin';
import { UrlParams } from '../../../types/url-params';
import { isArrayEmpty } from '../../../utils/array';
import { sanitize } from '../../../utils/index';
import { WireMetadata } from '../../../wiring/wiring.types';
import { SnippetConfig } from '../../../x-installer/api/api.types';
import { initialUrlState } from '../store/initial-state';
Expand Down Expand Up @@ -255,10 +256,13 @@
const urlKey = this.getUrlKey(name);
if (urlSearchParams.has(urlKey)) {
if (name in initialUrlState) {
const urlValue = urlSearchParams.getAll(urlKey);
let urlValue = urlSearchParams.getAll(urlKey);
urlValue[0] = sanitize(urlValue[0]);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be safe we should sanitize all values and not just the first one. The query only has one occurrence but potentially any parameter could be malicious.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

urlValue is not only query param, all URL params are passing one by one. [0] is necessary because urlValue is an array of only one element, the param that is being checked.

For example, try to search for a query and select a filter, then write the special characters (<>) in the filter and in the query.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I think I did not explain properly 😅 What I meant is that a url param can have more than one occurrence. Think about filters, you can select more than one filter at the same time. In that scenario you get an array with multiple entries like:

['categoryIds:12fad53d7', 'price:1600.0-2000.0']

so if you only pick the first element, you will fail to sanitize the other values.

params.all[name] = this.parseUrlParam(name, urlValue);
} else {
params.all[name] = params.extra[name] = urlSearchParams.get(urlKey);
let urlValueExtra = urlSearchParams.get(urlKey);
urlValueExtra = sanitize(urlValueExtra!);
params.all[name] = params.extra[name] = urlValueExtra;
}
}
return params;
Expand Down