drop root-selector usage

empathyco · May 2, 2024 · ca78b79 · ca78b79
1 parent 8924f18
commit ca78b79
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/packages/_vue3-migration-test/src/components/scroll/test-scroll.vue b/packages/_vue3-migration-test/src/components/scroll/test-scroll.vue
@@ -6,7 +6,7 @@
 </script>
 
 <template>
-  <MainScroll root-selector="#rootScroll">
+  <MainScroll>
     <ul id="rootScroll" class="list" data-test="scroll">
       <MainScrollItem v-for="item in items" :key="item.id" class="item" tag="article" :item="item">
         {{ item.id }}

diff --git a/packages/x-components/src/components/layouts/multi-column-max-width-layout.vue b/packages/x-components/src/components/layouts/multi-column-max-width-layout.vue
@@ -69,7 +69,7 @@
         </Scroll>
       </BaseIdTogglePanel>
 
-      <MainScroll root-selector="#main-scroll" class="x-flex x-flex-auto">
+      <MainScroll class="x-flex x-flex-auto">
         <Scroll v-if="hasContent('main-body')" id="main-scroll" class="x-layout__body-scroll">
           <section class="x-layout__main-body x-list x-list--vertical">
             <!-- @slot Slot that can be used to insert the body content. -->

diff --git a/packages/x-components/tests/unit/main-scroll.spec.ts b/packages/x-components/tests/unit/main-scroll.spec.ts
@@ -25,7 +25,7 @@ function renderMainScroll({
   windowScrollingElement,
   template = `
       <MainScroll v-bind="{ threshold, margin, useWindow }"
-                  root-selector="#rootScroll" class="root-scroll">
+                  class="root-scroll">
         <div id="rootScroll" class="container" ${!useWindow ? `data-test="scroll"` : ''}>
           <MainScrollItem
             v-for="item in items"
@@ -166,7 +166,7 @@ describe('testing MainScroll component', () => {
         const { restoreScrollToItem, getItem } = renderMainScroll({
           ...defaultParameters,
           template: `
-            <MainScroll v-bind="{ threshold, margin, useWindow }" root-selector="#rootScroll">
+            <MainScroll v-bind="{ threshold, margin, useWindow }">
               <div data-test="main-scroll" id="rootScroll">
                 <StaggeredFadeAndSlide>
                   <MainScrollItem