refactor(tagging): change sessionId creation logic from nanoId to UUID (

#1398)
empathyco · Jan 30, 2024 · be06367 · be06367
1 parent acf1eb3
commit be06367
Show file tree

Hide file tree

Showing 5 changed files with 3,039 additions and 8,133 deletions.
diff --git a/packages/x-components/src/x-modules/tagging/store/__tests__/actions.spec.ts b/packages/x-components/src/x-modules/tagging/store/__tests__/actions.spec.ts
@@ -16,6 +16,16 @@ describe('testing tagging module actions', () => {
   localVue.config.productionTip = false; // Silent production console messages.
   localVue.use(Vuex);
 
+  const selfSpy = jest.spyOn(self, 'self', 'get') as jest.SpyInstance<{
+    crypto: { randomUUID: () => string };
+  }>;
+
+  selfSpy.mockImplementation(() => ({
+    crypto: {
+      randomUUID: () => Math.floor(Math.random() * 1000000000).toString()
+    }
+  }));
+
   const store: SafeStore<TaggingState, TaggingGetters, TaggingMutations, TaggingActions> =
     new Store(taggingXStoreModule as any);
   installNewXPlugin({ adapter, store }, localVue);

diff --git a/packages/x-utils/package.json b/packages/x-utils/package.json
@@ -35,7 +35,6 @@
   },
   "dependencies": {
     "@empathyco/x-storage-service": "^2.0.3-alpha.0",
-    "nanoid": "~3.3.0",
     "tslib": "~2.6.0"
   },
   "devDependencies": {

diff --git a/packages/x-utils/src/services/__tests__/session.service.spec.ts b/packages/x-utils/src/services/__tests__/session.service.spec.ts
@@ -6,6 +6,16 @@ describe('testing session id service', () => {
   const sessionService = new DefaultSessionService(mockedStorageService, 1);
   const storageKey = DefaultSessionService.SESSION_ID_KEY;
 
+  const selfSpy = jest.spyOn(self, 'self', 'get') as jest.SpyInstance<{
+    crypto: { randomUUID: () => string };
+  }>;
+
+  selfSpy.mockImplementation(() => ({
+    crypto: {
+      randomUUID: () => Math.floor(Math.random() * 1000000000).toString()
+    }
+  }));
+
   const getItemSpy = jest.spyOn(mockedStorageService, 'getItem');
   const setItemSpy = jest.spyOn(mockedStorageService, 'setItem');
   const removeItemSpy = jest.spyOn(mockedStorageService, 'removeItem');

diff --git a/packages/x-utils/src/services/session.service.ts b/packages/x-utils/src/services/session.service.ts
@@ -1,4 +1,3 @@
-import { nanoid } from 'nanoid';
 import {
   BrowserStorageService,
   InMemoryStorageService,
@@ -39,7 +38,8 @@ export class DefaultSessionService implements SessionService {
    * @public
    */
   getSessionId(): string {
-    const sessionId = this.storageService.getItem(DefaultSessionService.SESSION_ID_KEY) ?? nanoid();
+    const sessionId =
+      this.storageService.getItem(DefaultSessionService.SESSION_ID_KEY) ?? self.crypto.randomUUID();
     this.storageService.setItem(DefaultSessionService.SESSION_ID_KEY, sessionId, this.ttlMs);
     return sessionId;
   }