feat: PR fixes

EMP-4342
empathyco · Jun 27, 2024 · b29a06b · b29a06b
1 parent 68fc2b1
commit b29a06b
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 7 deletions.
diff --git a/packages/_vue3-migration-test/src/x-modules/facets/components/test-facets.vue b/packages/_vue3-migration-test/src/x-modules/facets/components/test-facets.vue
@@ -13,8 +13,8 @@
                   :facet="facet"
                   class="x-facet-filter-lg x-mb-8 x-w-full"
                 >
-                  <label for="all">
-                    <input id="all" type="checkbox" :checked="isSelected" />
+                  <label :for="facet.id">
+                    <input :id="facet.id" type="checkbox" :checked="isSelected" />
                     All
                   </label>
                 </AllFilter>

diff --git a/packages/x-components/src/x-modules/facets/components/filters/all-filter.vue b/packages/x-components/src/x-modules/facets/components/filters/all-filter.vue
@@ -21,11 +21,10 @@
   import { Dictionary } from '@empathyco/x-utils';
   import BaseEventButton from '../../../../components/base-event-button.vue';
   import { isArrayEmpty } from '../../../../utils/array';
-  import { VueCSSClasses } from '../../../../utils/types';
   import { XEventsTypes } from '../../../../wiring/events.types';
   import { FiltersByFacet } from '../../store';
   import { facetsXModule } from '../../x-module';
-  import { useGetter } from '../../../../composables';
+  import { useGetter } from '../../../../composables/use-getter';
 
   /**
    * This component receives a required `facet` with
@@ -49,7 +48,6 @@
         required: true
       }
     },
-
     setup(props) {
       /** The getter of the selectedFiltersByFacet. */
       const { selectedFiltersByFacet }: Dictionary<ComputedRef<FiltersByFacet>> = useGetter(
@@ -72,7 +70,7 @@
        *
        * @returns True if is selected false otherwise.
        */
-      const isSelected = computed((): boolean => {
+      const isSelected = computed(() => {
         return isArrayEmpty(selectedFiltersByFacet.value?.[props.facet.id]);
       });
 
@@ -85,7 +83,7 @@
        * @returns The dynamic CSS classes to apply to the component.
        * @internal
        */
-      const cssClasses = computed((): VueCSSClasses => {
+      const cssClasses = computed(() => {
         return {
           'x-selected x-all-filter--is-selected': isSelected.value
         };