refactor(no-element): towards getting rid of no-element component

empathyco · Jul 23, 2024 · 9f9b315 · 9f9b315
1 parent bc66d07
commit 9f9b315
Show file tree

Hide file tree

Showing 11 changed files with 269 additions and 512 deletions.
diff --git a/packages/_vue3-migration-test/src/x-modules/facets/components/test-facets.vue b/packages/_vue3-migration-test/src/x-modules/facets/components/test-facets.vue
@@ -37,10 +37,12 @@
       </template>
     </Facets>
     <h2>SelectedFilters</h2>
-    <SelectedFilters :facetsIds="facetsIds" alwaysVisible>
-      <template #default="{ selectedFilters }">
-        Selected filters: {{ selectedFilters.length }}
-      </template>
+    <SelectedFilters
+      class="it-is-a-inheritance-class"
+      :facetsIds="facetsIds"
+      #default="{ selectedFilters }"
+    >
+      <span>Selected filters: {{ selectedFilters.length }}</span>
     </SelectedFilters>
     <h2>SelectedFiltersList</h2>
     <SelectedFiltersList :facetsIds="facetsIds" alwaysVisible>

diff --git a/packages/x-components/src/components/modals/base-id-modal-close.vue b/packages/x-components/src/components/modals/base-id-modal-close.vue
@@ -21,7 +21,7 @@
 <script lang="ts">
   import { defineComponent } from 'vue';
   import { NoElement } from '../no-element';
-  import { use$x } from '../../composables/index';
+  import { use$x } from '../../composables/use-$x';
 
   /**
    * Component that allows to close a modal by emitting