refactor(animation-factory): improve type infer

empathyco · Aug 5, 2024 · 77f4320 · 77f4320
1 parent 5dbaeec
commit 77f4320
Showing 1 changed file with 5 additions and 7 deletions.
diff --git a/packages/x-components/src/components/animations/create-directional-animation-factory.ts b/packages/x-components/src/components/animations/create-directional-animation-factory.ts
@@ -1,4 +1,4 @@
-import { defineComponent, h, Transition } from 'vue';
+import { DefineComponent, defineComponent, h, Transition } from 'vue';
 
 export type AnimationOrigin =
   | 'top'
@@ -21,18 +21,16 @@ export type AnimationOrigin =
  */
 export function createDirectionalAnimationFactory(
   animationName: string
-): ReturnType<typeof defineComponent> {
-  return (animationOrigin: AnimationOrigin = 'top') =>
+): (animationOrigin?: AnimationOrigin) => DefineComponent {
+  return (animationOrigin = 'top') =>
     defineComponent({
       name: `transition-${animationName}-${animationOrigin}`,
-      inheritAttrs: false,
-      setup(_, { attrs, slots }) {
+      setup(_, { slots }) {
         return () =>
           h(
             Transition,
             {
-              name: `x-${animationName}--${animationOrigin} x-${animationName}-`,
-              ...attrs
+              name: `x-${animationName}--${animationOrigin} x-${animationName}-`
             },
             // Vue recommends using function for better performance.
             () => slots.default?.() ?? ''