feat(renderless-filter): fix the css classes

empathyco · Jul 25, 2024 · 0265afd · 0265afd
1 parent 790b494
commit 0265afd
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 9 deletions.
diff --git a/packages/_vue3-migration-test/src/x-modules/facets/components/test-filters.vue b/packages/_vue3-migration-test/src/x-modules/facets/components/test-filters.vue
@@ -5,8 +5,8 @@
     <SimpleFilter
       :filter="filter"
       :cssClasses="innerCssClasses"
-      class="this-is-not-inherited-in-vue3-use-cssClasses-prop-instead"
-      data-custom="this-is-not-inherited-in-vue3"
+      class="this-is-not-inherited-in-vue3-and-will-throw-a-warning--use-cssClasses-prop-instead"
+      data-custom="this-is-not-inherited-in-vue3-and-will-throw-a-warning"
     />
   </div>
   <div>

diff --git a/packages/x-components/src/views/home/aside.vue b/packages/x-components/src/views/home/aside.vue
@@ -4,7 +4,7 @@
     <ClearFilters />
     <SelectedFiltersList>
       <template #default="{ filter }">
-        <SimpleFilter :filter="filter" class="x-facet-filter-success">
+        <SimpleFilter :filter="filter" :cssClasses="['x-facet-filter-success']">
           <template #label>{{ filter.label ?? filter.id }}</template>
         </SimpleFilter>
       </template>
@@ -67,7 +67,7 @@
                   </span>
                 </SelectedFilters>
                 <FiltersList v-slot="{ filter }">
-                  <SimpleFilter #label :filter="filter" :data-test="`${facet.label}-filter`">
+                  <SimpleFilter #label :filter="filter">
                     <BasePriceFilterLabel
                       v-if="facet.id === 'price'"
                       :filter="filter"
@@ -107,11 +107,7 @@
                       filter
                     }"
                   >
-                    <SimpleFilter
-                      #label="{ filter }"
-                      :filter="filter"
-                      :data-test="`${facet.label}-filter`"
-                    >
+                    <SimpleFilter #label="{ filter }" :filter="filter">
                       {{ filter.label }}
                       <span :data-test="`${facet.label}-filter-total-results`">
                         {{ filter.totalResults }}