Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Fix RPs layout for mobile devices #525

Merged
merged 5 commits into from
Dec 11, 2024

Conversation

annacv
Copy link
Contributor

@annacv annacv commented Dec 10, 2024

Pull request template

Describe the purpose of the change, the specific changes done in detail, and the issue you have fixed.

Motivation and context

  • Dependencies. If any, specify:
  • Open issue. If applicable, link:

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that causes existing functionality to not work as expected)
  • Change requires a documentation update

What is the destination branch of this PR?

  • Main
  • Other. Specify:

How has this been tested?

Tests performed according to testing guidelines:

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review on my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

@annacv annacv requested a review from a team as a code owner December 10, 2024 14:36
Copy link

Check PR 525 preview 👀

https://x.test.empathy.co/preview/525/index.html

Copy link

Check PR 525 preview 👀

https://x.test.empathy.co/preview/525/index.html

Copy link
Contributor

@victorcg88 victorcg88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO, the prompt's top and bottom margins could look better if they were the same. WDYT?

image

Also, I'm wondering if we should add still a bit more space to the bottom, so the prompt is completely visible

image

But this is subjective. Maybe it is worth asking the rest of the team.

src/components/main.vue Show resolved Hide resolved
package-lock.json Outdated Show resolved Hide resolved
Copy link

Check PR 525 preview 👀

https://x.test.empathy.co/preview/525/index.html

Copy link

Check PR 525 preview 👀

https://x.test.empathy.co/preview/525/index.html

Copy link

Check PR 525 preview 👀

https://x.test.empathy.co/preview/525/index.html

@annacv annacv merged commit 5497ee1 into main Dec 11, 2024
4 checks passed
@annacv annacv deleted the feature/RST-2569-Fix-RTP-layout branch December 11, 2024 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants