chore(deps): use @empathyco/eslint-config as code format config #514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
victorcg88
force-pushed
the
chore/use-empathy-eslint
branch
from
7ee3b77 to
b71e9f1
Compare
|
Check PR 514 preview 👀 |
|
Check PR 514 preview 👀 |
|
Check PR 514 preview 👀 |
|
Check PR 514 preview 👀 |
|
Check PR 514 preview 👀 |
diegopf
requested changes
Nov 27, 2024
eslint.config.mjs
Outdated
Comment on lines
6
to
9
| rules: { | ||
| 'vuejs-accessibility/no-autofocus': 'off', | ||
| 'vue/multi-word-component-names': 'off', | ||
| 'node/prefer-global/process': 'off', |
There was a problem hiding this comment.
I think we can remove this configuration. The only rule that seems we are violating is the node/prefer-global/process and I'd just disable it on the plugin.options.ts file
|
Check PR 514 preview 👀 |
diegopf
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request template
Pull Request Blocked by #513
Change legacy
@empathyco/eslint-plugin-xby the new@empathyco/eslint-configMotivation and context
Type of change
What is the destination branch of this PR?
MainHow has this been tested?
Tests performed according to testing guidelines:
Checklist: