Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(scroll): reactivate e2e tests #507

Merged
merged 1 commit into from
Oct 4, 2024
Merged

Conversation

victorcg88
Copy link
Contributor

@victorcg88 victorcg88 commented Oct 4, 2024

Pull request template

Enables e2e tests for scroll after the fix about the scroll direction inconsistency on X is released.

Motivation and context

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that causes existing functionality to not work as expected)
  • Change requires a documentation update

What is the destination branch of this PR?

  • Main

How has this been tested?

Tests performed according to testing guidelines:

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review on my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

@victorcg88 victorcg88 requested a review from a team as a code owner October 4, 2024 08:16
Copy link

github-actions bot commented Oct 4, 2024

Check PR 507 preview 👀

https://x.test.empathy.co/preview/507/index.html

@joseacabaneros joseacabaneros merged commit e1e87de into main Oct 4, 2024
4 checks passed
@joseacabaneros joseacabaneros deleted the scroll-e2e-tests branch October 4, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants