Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(next-queries): add displayClick track to next queries preview #349

Merged
merged 2 commits into from
Oct 31, 2023
Merged

feat(next-queries): add displayClick track to next queries preview #349

merged 2 commits into from
Oct 31, 2023

Conversation

herrardo
Copy link
Contributor

@herrardo herrardo commented Oct 30, 2023 •
edited
Loading

EMP-2716

Pull request template

Add DisplayClickPRovider to Next Query Preview Resutls

Motivation and context

Track this kind of carousels in the same way as topclicked recommendations and brand recommendations

  • Dependencies. If any, specify:
  • Open issue. If applicable, link:

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that causes existing functionality to not work as expected)
  • Change requires a documentation update

What is the destination branch of this PR?

  • Main
  • Other. Specify:

How has this been tested?

Tests performed according to testing guidelines:

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review on my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

@herrardo herrardo requested a review from a team as a code owner October 30, 2023 08:22
@support-empathy
Copy link
Contributor

Check PR 349 preview 👀

https://x.test.empathy.co/preview/349/index.html

@herrardo herrardo marked this pull request as draft October 30, 2023 08:48
@herrardo herrardo marked this pull request as ready for review October 31, 2023 08:46
@support-empathy
Copy link
Contributor

Check PR 349 preview 👀

https://x.test.empathy.co/preview/349/index.html

@CachedaCodes CachedaCodes merged commit 57d139a into main Oct 31, 2023
4 checks passed
@CachedaCodes CachedaCodes deleted the feat/add-display-click-to-next-queries-preview branch October 31, 2023 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CachedaCodes CachedaCodes CachedaCodes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@herrardo @support-empathy @CachedaCodes