Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add fallback disclaimer for removing filters #321

Merged
merged 2 commits into from
Oct 9, 2023

Conversation

CachedaCodes
Copy link
Contributor

EMP-2097

Motivation and context

We wanted to add de fallback disclaimer component to the archetype.

Also, in this PR I have extracted the stylings of the messages to a component class and added translations.
No tests were created for this because the feature depends heavily on the behaviour of the endpoint and it not being mocked makes the tests too flakey.

  • Dependencies. If any, specify:
  • Open issue. If applicable, link:

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that causes existing functionality to not work as expected)
  • Change requires a documentation update

What is the destination branch of this PR?

  • Main
  • Other. Specify:

How has this been tested?

Search for sneaker high-top -> Add filter Gender>Unisex -> Search for sneaker high-top pink -> The message should appear.

Tests performed according to testing guidelines:

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review on my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

@CachedaCodes CachedaCodes requested a review from a team as a code owner September 28, 2023 14:08
@jenkins-empathy
Copy link

PR #321 preview deployed in https://x.test.empathy.co/preview/321/index.html

Copy link
Contributor

@herrardo herrardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something is not working well...

Screen.Recording.2023-09-29.at.12.19.25.mov

@jenkins-empathy
Copy link

PR #321 preview deployed in https://x.test.empathy.co/preview/321/index.html

@CachedaCodes CachedaCodes merged commit 8567c40 into main Oct 9, 2023
2 checks passed
@CachedaCodes CachedaCodes deleted the feature/EMP-2097-add-fallback-disclaimer branch October 9, 2023 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants