Skip to content

Commit

Permalink
feat(tagging): set proper resultFeatures values for displayClick event
Browse files Browse the repository at this point in the history
  • Loading branch information
herrardo committed Oct 31, 2023
1 parent 7300ed7 commit 6fd9342
Show file tree
Hide file tree
Showing 6 changed files with 145 additions and 30 deletions.
165 changes: 140 additions & 25 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
"@empathyco/x-adapter": "^8.0.0-alpha.34",
"@empathyco/x-adapter-platform": "^1.0.0-alpha.88",
"@empathyco/x-archetype-utils": "^1.0.0-alpha.4",
"@empathyco/x-components": "^3.0.0-alpha.422",
"@empathyco/x-components": "^3.0.1-alpha.4",
"@empathyco/x-deep-merge": "^1.3.0-alpha.34",
"@empathyco/x-types": "^10.0.0-alpha.75",
"@empathyco/x-utils": "^1.0.0-alpha.23",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@

<Recommendations class="x-flex x-flex-row x-gap-12 x-pl-16 desktop:x-pl-0">
<template #default="{ recommendation }">
<DisplayClickProvider resultFeature="recommendations">
<DisplayClickProvider resultFeature="topclicked_recommendations">
<Result
:result="recommendation"
data-test="recommendation-item"
Expand Down
2 changes: 1 addition & 1 deletion src/components/results/custom-recommendations.vue
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
</h1>
<Recommendations v-if="!$x.totalResults">
<template #layout="{ recommendations }">
<DisplayClickProvider resultFeature="recommendations">
<DisplayClickProvider resultFeature="topclicked_recommendations">
<BaseGrid
#default="{ item: result }"
:animation="staggeredFadeAndSlide"
Expand Down
2 changes: 1 addition & 1 deletion src/components/search/custom-semantic-queries.vue
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
<ArrowRightIcon class="x-icon-lg" />
</SemanticQuery>
</template>
<DisplayClickProvider resultFeature="semantics">
<DisplayClickProvider resultFeature="semantic_recommendations">
<div class="x-flex x-gap-16 x-pt-16 max-desktop:x-px-16">
<Result
v-for="result in results.slice(0, resultsPerCarousel)"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
itemClass="x-flex-shrink-0"
>
<template #result="{ item: result }">
<DisplayClickProvider resultFeature="next_query_results">
<DisplayClickProvider resultFeature="next_query_recommendations">
<Result :result="result" class="x-w-[calc(38vw-16px)] desktop:x-max-w-[265px]" />
</DisplayClickProvider>
</template>
Expand Down

0 comments on commit 6fd9342

Please sign in to comment.