Skip to content

Commit

Permalink
chore: refactor aws args and test the deployment in test bucket root
Browse files Browse the repository at this point in the history
  • Loading branch information
lauramargar committed Oct 26, 2023
1 parent ccb2306 commit 4f4d184
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 9 deletions.
16 changes: 8 additions & 8 deletions .github/workflows/build.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -17,12 +17,12 @@ jobs:
node-version: '18'
- name: Install deps, build and test project
uses: ./.github/actions/install
# - name: Deploy to staging
- name: Deploy to staging
# if: ${{ github.ref_name == 'main' }}
# uses: ./.github/actions/deploy
# with:
# aws_role: ${{ secrets.AWS_ROLE_STAGING_ACCOUNT }}
# aws_deploy_path: ${{ secrets.AWS_STAGING_BUCKET }}
# aws_s3_sync_args: '--include \"*\" --exclude \"*/*\"'
# cloudfront_distribution_id: ${{ secrets.CLOUDFRONT_ID_STAGING }}
# cloudfront_invalidation_paths: '/*'
uses: ./.github/actions/deploy
with:
aws_role: ${{ secrets.AWS_ROLE_TEST_ACCOUNT }}
aws_deploy_path: ${{ secrets.TEST_BUCKET }}
aws_s3_sync_args: --include '*' --exclude '*/*'
cloudfront_distribution_id: ${{ secrets.CLOUDFRONT_ID_TEST }}
cloudfront_invalidation_paths: '/*'
2 changes: 1 addition & 1 deletion .github/workflows/pull-request.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ jobs:
with:
aws_role: ${{ secrets.AWS_ROLE_TEST_ACCOUNT }}
aws_deploy_path: ${{ secrets.TEST_BUCKET }}/preview/${{ github.event.number }}
aws_s3_sync_args: '--include \"*\" --exclude \"*/*\"'
aws_s3_sync_args: --include '*' --exclude '*/*'
cloudfront_distribution_id: ${{ secrets.CLOUDFRONT_ID_TEST }}
cloudfront_invalidation_paths: '/preview/${{ github.event.number }}/*'
- name: Adding comment to PR with preview link and validation results
Expand Down

0 comments on commit 4f4d184

Please sign in to comment.