-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore all webkit, ms and Mozilla specific pseudo elements #3150
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 98b889a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 98b889a:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
|
Those are known to be vendor-prefixed though so perhaps this would just cover everything automatically without a huge risk of false positives? |
Sounds reasonable to me, though I may not have enough CSS/emotion knowledge to make that judgement. Do you want me to update the PR to use that filter instead? |
I've changed the PR to use the more generic regex. Here is an example to show that all three types of vendor-prefixes are still caught:
|
@Andarist Any chance you could take a look at the latest version? |
What:
Adds
-webkit-scrollbar-button
,-webkit-scrollbar-thumb
andwebkit-scrollbar-track
to ignored vendor prefixes, similar to #2920, #2393 and #2149. Fixes #3111.Why:
These errors appear in non-webkit-browsers (Firefox) when using these webkit specific pseudo-elements.
These are only the ones we specifically use, I don't know if we want to add a more comprehensive list, or perhaps do a filter like
:(-webkit-:.*|-moz-.*|-ms-.*){
(though that may risk introducing false positives?)?How:
The existing regex was extended.
Checklist: