Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev simon #59

Merged
merged 19 commits into from
Aug 18, 2023
Merged

Dev simon #59

merged 19 commits into from
Aug 18, 2023

Conversation

jsimonclark
Copy link
Collaborator

updates the emmo version to 1.0.0-beta5, which includes many of the extensions on quantities and si units.
refactor file structure for beta5 integration.
- adapted structure for emmo v1.0.0-beta5
- included terns from IEC 60050 Area 114: Electrochemistry
- check elucidations for all terms
added annotations to other sources where available
@jsimonclark jsimonclark added the enhancement New feature or request label Jul 28, 2023
Copy link
Collaborator

@eibar-flores eibar-flores left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very complete upgrade to electrochemistry-domain. Most comments are minor edits, some other are thoughts to consider on how to describe/categorize entities. Overall, after the minor edits, I think the 0.6.0 release is good to go!

electrochemicalquantities.ttl Show resolved Hide resolved
electrochemicalquantities.ttl Show resolved Hide resolved
electrochemicalquantities.ttl Show resolved Hide resolved
electrochemicalquantities.ttl Show resolved Hide resolved
electrochemicalquantities.ttl Show resolved Hide resolved
electrochemistry.ttl Outdated Show resolved Hide resolved
electrochemistry.ttl Outdated Show resolved Hide resolved
electrochemistry.ttl Show resolved Hide resolved
electrochemistry.ttl Show resolved Hide resolved
electrochemistry.ttl Show resolved Hide resolved
@jsimonclark jsimonclark merged commit e7fe992 into 0.6.0 Aug 18, 2023
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants