Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated computer science #255

Merged
merged 14 commits into from
Jan 12, 2024
Merged

Updated computer science #255

merged 14 commits into from
Jan 12, 2024

Conversation

jesper-friis
Copy link
Contributor

@jesper-friis jesper-friis commented Nov 5, 2023

Updated computer science based on the categorisation on https://en.wikipedia.org/wiki/Computer_language

Added elucidations and other annotations.

NOTE: This PR builds on top of PR #254. Either merge that PR first or only consider the changes in disciplines/computerscience.ttl.

@jesper-friis jesper-friis changed the base branch from master to 1.0.0-beta5 November 5, 2023 22:03
@jesper-friis jesper-friis marked this pull request as draft November 5, 2023 22:11
@hothello
Copy link
Collaborator

hothello commented Nov 7, 2023

A bunch of random comments.

  1. In the openmodel ontology for D5.5, I have added the class Filename, which is a subclass of URL and the union of Root and Extension. I used these classes to break down the ResourceDescription into their constituents.
  2. Given point 1, the class File could have an additional restriction:
    hasURL exactly 1 Filename.
  3. Would it make sense to make ResourceDescription also a subclass of String? In this way, we make it a SymbolicConstruct. Currently, only the class Path is a subclass of String.
  4. The class File contains only a subclass LanguageInterpretableFile. I would also add BinaryFile.
  5. I like very much the classification of ComputerSystem.

@jesper-friis
Copy link
Contributor Author

Thanks a lot Otello. Some quick comments:

  1. How established are the terminology Root and Extension? Python pathlib uses the terms: name, suffix and stem. Are these more established terms? Possible altLabels?

  2. What about hard and symbolic links? They allow associating several filenames to a file. I think it is better to change the relation to hasURL some Filename.

  3. Good question. But must all resource descriptions really be strings? In OTEAPI we use Python dicts. Transferred between memory and CPU they are just data.

  4. Agree

  5. Thanks :-)

@jesper-friis jesper-friis marked this pull request as ready for review January 3, 2024 21:39
@emanueleghedini emanueleghedini merged commit ee5330a into 1.0.0-beta5 Jan 12, 2024
1 check failed
@emanueleghedini emanueleghedini deleted the computer-science branch January 12, 2024 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants