Fixes the typo raised in issue viash-hub#132 (viash-hub#157)

* Fixes the typo raised in issue viash-hub#132 * Add changelog entry * fix typo, modify script --------- Co-authored-by: jakubmajercik <[email protected]>
emmarousseau · Sep 27, 2024 · 237a2e3 · 237a2e3
1 parent 63de1c1
commit 237a2e3
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -9,6 +9,10 @@
 
 * `rsem/rsem_calculate_expression`: Calculate expression levels (PR #93).
 
+## BREAKING CHANGES
+
+* `falco`: Fix a typo in the `--reverse_complement` argument (PR #157).
+
 ## MINOR CHANGES
 
 * Upgrade to Viash 0.9.0.

diff --git a/src/falco/config.vsh.yaml b/src/falco/config.vsh.yaml
@@ -86,7 +86,7 @@ argument_groups:
           bisulfite sequencing, and more Ts and fewer 
           Cs are therefore expected and will be 
           accounted for in base content.
-      - name: --reverse_complliment
+      - name: --reverse_complement
         alternatives: [-r]
         type: boolean_true
         description: |

diff --git a/src/falco/script.sh b/src/falco/script.sh
@@ -4,7 +4,7 @@ set -eo pipefail
 
 [[ "$par_nogroup" == "false" ]] && unset par_nogroup
 [[ "$par_bisulfite" == "false" ]] && unset par_bisulfite
-[[ "$par_reverse_compliment" == "false" ]] && unset par_reverse_compliment
+[[ "$par_reverse_complement" == "false" ]] && unset par_reverse_complement
 
 IFS=";" read -ra input <<< $par_input
 
@@ -15,7 +15,7 @@ $(which falco) \
   ${par_limits:+--limits "$par_limits"} \
   ${par_subsample:+-subsample $par_subsample} \
   ${par_bisulfite:+-bisulfite} \
-  ${par_reverse_compliment:+-reverse-compliment} \
+  ${par_reverse_complement:+-reverse-complement} \
   ${par_outdir:+--outdir "$par_outdir"} \
   ${par_format:+--format "$par_format"} \
   ${par_data_filename:+-data-filename "$par_data_filename"} \