Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn if node labels mismatched #115

Merged

Conversation

ms609
Copy link
Contributor

@ms609 ms609 commented Mar 28, 2024

Resolves #113

@stitam
Copy link

stitam commented Apr 2, 2024

Many thanks @ms609. I am wondering if warning() is strong enough, I would probably fix an inconsistent phylo object before going further, just to be safe. Do you think stop() would be too much?

@ms609
Copy link
Contributor Author

ms609 commented Apr 2, 2024

I went for warning() because there's no absolute necessity to abort – a user may have some obscure and unanticipated reason for wishing to override the sanity check and proceed with mismatched labels.

@emmanuelparadis emmanuelparadis merged commit 44b811e into emmanuelparadis:master Apr 7, 2024
0 of 9 checks passed
@emmanuelparadis
Copy link
Owner

Many thanks for this. Now merged and pushed a new version here with updated files.
Almost ready to submit v. 5.8 to CRAN!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

write.tree() may export duplicate internal node labels without notification
3 participants