Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some small improvements #111

Merged
merged 4 commits into from
Feb 13, 2024
Merged

Conversation

KlausVigo
Copy link
Contributor

Hi @emmanuelparadis,
a few little improvements. I hope these don't collide with your recent improvements. In comparePhylo I clean up after running layout. degree.phylo might be a bit slower, but should be save if a tree has not tip.label slot, like compressed trees. I think you solved this problem differently. To read.genBank I added an argument type to allow to download protein / amino acids.
Kind regards,
Klaus

@emmanuelparadis emmanuelparadis merged commit abd06a7 into emmanuelparadis:master Feb 13, 2024
2 of 9 checks passed
emmanuelparadis added a commit that referenced this pull request Feb 13, 2024
@emmanuelparadis
Copy link
Owner

All good!

I edited a bit read.GenBank() since an if .... seemed redundant as type was already set. More tests might be useful too.

I updated the NEWS and incremented the version and pushed here.

Thanks!
Emmanuel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants