Fix stick calibration #22
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Reading more carefully issue #8, I realize you had already identified the commit which introduced the regression. And that I've just reintroduced the missing lines with this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was experiencing issues #8 / #18 on my NSO N64 controler.
Digging in the code, I found that min/max calibration are not properly set during nx_con_read_stick_calibration().
Hence, it always returns EINVAL (because returned calibration values don't satisfy "min < center < max").
According to dekuNukem joycon reverse engineering, the min and max values read from SPI are relative to the center.
So the actual calibration values should be center-min < center < center+max.