Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Little changes ))) #8

Open
wants to merge 17 commits into
base: master
Choose a base branch
from
Open

Little changes ))) #8

wants to merge 17 commits into from

Conversation

jackkum
Copy link

@jackkum jackkum commented Oct 29, 2015

Ported from this https://github.com/jackkum/PHPPDU

Was too many "todo" in this module 😃

@emilsedgh
Copy link
Owner

Wow this is a huge change! Would you like to take over the module as maintainer?
And is it compatible with older version?

@jackkum
Copy link
Author

jackkum commented Oct 29, 2015

Why not, I can try.

Here is I made support 'generate' method: https://github.com/jackkum/pdu/blob/master/pdu.js#L81
here supporting 'parseStatusReport': https://github.com/jackkum/pdu/blob/master/pdu.js#L116
and here 'parse': https://github.com/jackkum/pdu/blob/master/pdu.js#L176

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jackkum @emilsedgh