Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added recursive-ci next to recursive-install. #11

Open
wants to merge 17 commits into
base: master
Choose a base branch
from

Conversation

ReinoutW
Copy link

@ReinoutW ReinoutW commented Jan 4, 2019

Since the functionality is very similar and at least a section of the code can be re-used (cfr. lib/tools.js) between both, I think it would make sense to store everything in a single git repository rather than maintaining multiple forks.

Changes:

  • Added recursive-ci supporting similar arguments as you added for recursive-install.
  • Added lib/tools.js for code sharing.
  • Updated dependencies and devDependencies (as some of them were outdated).
  • Updated the test folder to accommodate tests for both packages (by renaming index.js and adding subfolders for test files, which will usually have the same or at least very similar names).
  • Created a build on travis to confirm everything is working.
  • Added the MIT license in the root of the repository.

ReinoutW and others added 17 commits January 2, 2019 14:52
Supporting production parameter.
Resolving tests:
 - no longer rely on node being the application associated with .js files on Windows.
 - added a test for an invalid package-lock.json file.
Upgraded dependencies and devDependencies to the latest versions.
Restructured tests to accommodate tests for recursive-install as well as recursive-ci.js
Added tools.js to re-use code between recursive-install and recursive-ci.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant